-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v16.x] doc: remove {C,Dec}ompressionStream documentation #39899
Closed
lpinca
wants to merge
1
commit into
nodejs:v16.x-staging
from
lpinca:remove/compression-decompression-stream-documentation
Closed
[v16.x] doc: remove {C,Dec}ompressionStream documentation #39899
lpinca
wants to merge
1
commit into
nodejs:v16.x-staging
from
lpinca:remove/compression-decompression-stream-documentation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
force-pushed
the
remove/compression-decompression-stream-documentation
branch
from
August 26, 2021 13:17
87bffb2
to
b86cfe6
Compare
I'm not sure if it's better to land this or wait for 09ad64d to be backported. |
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Aug 26, 2021
Documentation for `CompressionStream` and `DecompressionStream` was erroneously added in nodejs@f57a0e4d8b and released in version 16.7.0. Reset the added: version to REPLACEME. Refs: nodejs#39348 Refs: nodejs#39899
Documentation for `CompressionStream` and `DecompressionStream` was erroneously added in nodejs@f57a0e4d8b. Fixes: nodejs#39895
lpinca
force-pushed
the
remove/compression-decompression-stream-documentation
branch
from
August 26, 2021 13:37
b86cfe6
to
8715e14
Compare
lpinca
changed the title
[v16.x] doc: remove {C,Deco}ompressionStream documentation
[v16.x] doc: remove {C,Dec}ompressionStream documentation
Aug 26, 2021
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Aug 26, 2021
Documentation for `CompressionStream` and `DecompressionStream` was erroneously added in nodejs@f57a0e4d8b and released in version 16.7.0. Reset the `added:` version to `REPLACEME`. Refs: nodejs#39348 Refs: nodejs#39899
jasnell
pushed a commit
that referenced
this pull request
Aug 28, 2021
Documentation for `CompressionStream` and `DecompressionStream` was erroneously added in f57a0e4d8b and released in version 16.7.0. Reset the `added:` version to `REPLACEME`. Refs: #39348 Refs: #39899 PR-URL: #39901 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
I'm closing this as per #39899 (comment). |
lpinca
deleted the
remove/compression-decompression-stream-documentation
branch
August 29, 2021 19:25
Do you know of anyone is working on a backport? |
@targos no, I will reopen. |
lpinca
restored the
remove/compression-decompression-stream-documentation
branch
August 30, 2021 05:40
targos
approved these changes
Sep 6, 2021
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
Documentation for `CompressionStream` and `DecompressionStream` was erroneously added in f57a0e4d8b. Fixes: #39895 PR-URL: #39899 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Landed in 9e782eb |
lpinca
deleted the
remove/compression-decompression-stream-documentation
branch
September 6, 2021 07:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for
CompressionStream
andDecompressionStream
waserroneously added in f57a0e4d8b.
Fixes: #39895